linux-kernel - [PATCH] fix use of REQ_WRITE in blk_rq_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <4C77E8E20200007800012970@vpn.id2.novell.com>
Date:	Fri, 27 Aug 2010 15:33:38 +0100
From:	"Jan Beulich" <JBeulich@...ell.com>
To:	<jaxboe@...ionio.com>, <hch@....de>
Cc:	<linux-kernel@...r.kernel.org>
Subject: [PATCH] fix use of REQ_WRITE in blk_rq_map_kern()

REQ_WRITE clearly isn't meant to be used as a shift count, other than
BIO_RW was.

Signed-off-by: Jan Beulich <jbeulich@...ell.com>

---
 block/blk-map.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.36-rc2/block/blk-map.c	2010-08-24 15:57:04.000000000 +0200
+++ 2.6.36-rc2-blk-map-REQ_WRITE/block/blk-map.c	2010-08-27 12:57:08.000000000 +0200
@@ -307,7 +307,7 @@ int blk_rq_map_kern(struct request_queue
 		return PTR_ERR(bio);
 
 	if (rq_data_dir(rq) == WRITE)
-		bio->bi_rw |= (1 << REQ_WRITE);
+		bio->bi_rw |= REQ_WRITE;
 
 	if (do_copy)
 		rq->cmd_flags |= REQ_COPY_USER;



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/