linux-kernel - Re: [PATCH 3/3 v2] dmaengine: Add Freescale i.MX SDMA support

Open Source and information security mailing list archives

Date:	Sat, 28 Aug 2010 17:27:10 +0200
From:	Marek Vasut <marek.vasut@...il.com>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Linus Walleij <linus.ml.walleij@...il.com>,
	"Uwe Kleine-König" 
	<u.kleine-koenig@...gutronix.de>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Dan Williams <dan.j.williams@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3 v2] dmaengine: Add Freescale i.MX SDMA support

Dne So 28. srpna 2010 17:18:17 Linus Walleij napsal(a):
> 2010/8/23 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>:
> >> +     evt = readl(SDMA_H_EVTOVR);
> >> +     mcu = readl(SDMA_H_HOSTOVR);
> >> +     dsp = readl(SDMA_H_DSPOVR);
> > 
> > __raw_readl?
> 
> Sorry I never understood this __raw_[read|write][b|w|l] vs.
> plain read[b|w|l] proliferation in some drivers and code.
> 
> What's the reason for?

Hey,

this trick is, if you create the VA<->PA mapping at the kernel start (eg. see 
how pxa_map_io() is replacedon some devices for instance), you then use the VA 
address you specified and use __raw_{read,write}[b,w,l](). So use 
__raw_{read,write}[b,w,l]() on drivers specific for certain device and use 
{read,write}[b,w,l]() on ioremap()ed memory areas, aka. in common drivers.

Cheers

> 
> Yours,
> Linus Walleij
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives