[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <1283000268.4789.1.camel@neuromancer>
Date: Sat, 28 Aug 2010 14:57:48 +0200
From: Stefan Achatz <erazor_de@...rs.sourceforge.net>
To: Jiri Kosina <jkosina@...e.cz>,
Stefan Achatz <erazor_de@...rs.sourceforge.net>,
Stephen Rothwell <sfr@...b.auug.org.au>,
Tejun Heo <tj@...nel.org>, linux-input@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH] HID: roccat: Fixing race condition on initialization
Fixed raced condition where event occurs before drvdata is set.
Signed-off-by: Stefan Achatz <erazor_de@...rs.sourceforge.net>
---
drivers/hid/hid-roccat-kone.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/hid-roccat-kone.c b/drivers/hid/hid-roccat-kone.c
index f776957..cfeab56 100644
--- a/drivers/hid/hid-roccat-kone.c
+++ b/drivers/hid/hid-roccat-kone.c
@@ -966,6 +966,10 @@ static int kone_raw_event(struct hid_device *hdev, struct hid_report *report,
struct kone_device *kone = hid_get_drvdata(hdev);
struct kone_mouse_event *event = (struct kone_mouse_event *)data;
+ /* possible race condition on initialization */
+ if (!kone)
+ return 0;
+
/* keyboard events are always processed by default handler */
if (size != sizeof(struct kone_mouse_event))
return 0;
--
1.7.2.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists