linux-kernel - Re: [PATCH 07/11] x86-64: Simplify constraints for fxsave/fxtstor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=+cEywooPp-ERx2+7GL3fs_d-xQ_fX9A7pc9St@mail.gmail.com>
Date:	Sun, 29 Aug 2010 21:45:11 +0300
From:	Pekka Enberg <penberg@...nel.org>
To:	Brian Gerst <brgerst@...il.com>
Cc:	hpa@...or.com, x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/11] x86-64: Simplify constraints for fxsave/fxtstor

On Sat, Aug 28, 2010 at 7:04 PM, Brian Gerst <brgerst@...il.com> wrote:
> Use the "R" constraint (legacy register) instead of listing all the
> possible registers.  Clean up the comments as well.
>
> Signed-off-by: Brian Gerst <brgerst@...il.com>
> ---
>  arch/x86/include/asm/i387.h |   44 ++++++++++++++++--------------------------
>  1 files changed, 17 insertions(+), 27 deletions(-)
>
> diff --git a/arch/x86/include/asm/i387.h b/arch/x86/include/asm/i387.h
> index 8b40a83..768fcb2 100644
> --- a/arch/x86/include/asm/i387.h
> +++ b/arch/x86/include/asm/i387.h
> @@ -81,6 +81,7 @@ static inline int fxrstor_checking(struct i387_fxsave_struct *fx)
>  {
>        int err;
>
> +       /* See comment in fxsave() below. */
>        asm volatile("1:  rex64/fxrstor (%[fx])\n\t"
>                     "2:\n"
>                     ".section .fixup,\"ax\"\n"
> @@ -89,11 +90,7 @@ static inline int fxrstor_checking(struct i387_fxsave_struct *fx)
>                     ".previous\n"
>                     _ASM_EXTABLE(1b, 3b)
>                     : [err] "=r" (err)
> -#if 0 /* See comment in fxsave() below. */
> -                    : [fx] "r" (fx), "m" (*fx), "0" (0));
> -#else
> -                    : [fx] "cdaSDb" (fx), "m" (*fx), "0" (0));
> -#endif
> +                    : [fx] "R" (fx), "m" (*fx), "0" (0));

Please correct me if I'm wrong but "legacy registers" also include bp
and sp that are not part of the original constraints:

http://gcc.gnu.org/onlinedocs/gcc/Machine-Constraints.html

So why is it OK to use "R" here?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/