linux-kernel - [RFC PATCH 1/6] timer: expliciyly call timer_stats_timer_set_start_info() in add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1283094309-6635-2-git-send-email-yong.zhang0@gmail.com>
Date:	Sun, 29 Aug 2010 23:05:04 +0800
From:	Yong Zhang <yong.zhang0@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	tglx@...utronix.de, akpm@...ux-foundation.org, mingo@...e.hu,
	arjan@...ux.intel.com, a.p.zijlstra@...llo.nl, tj@...nel.org,
	oleg@...hat.com
Subject: [RFC PATCH 1/6] timer: expliciyly call timer_stats_timer_set_start_info() in add_timer()

From: Yong Zhang <yong.zhang@...driver.com>

Now /proc/timer_stats will show add_timer() as the start_site:
   23,     0 swapper          add_timer (peer_check_expire)
   23,     0 swapper          add_timer (addrconf_verify)

This is because add_timer() -> mod_timer() -> __mod_timer(),
but mod_timer() is not inlined. So add_timer() is showed.
Call timer_stats_timer_set_start_info() explicitly to record the
real start_site.

After this change, timer_stats_timer_set_start_info() in workqueue.c
can be removed.

Signed-off-by: Yong Zhang <yong.zhang0@...il.com>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Ingo Molnar <mingo@...e.hu>
Cc: Arjan van de Ven <arjan@...ux.intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
---
 kernel/timer.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/timer.c b/kernel/timer.c
index 97bf05b..2a443cc 100644
--- a/kernel/timer.c
+++ b/kernel/timer.c
@@ -864,6 +864,7 @@ EXPORT_SYMBOL(mod_timer_pinned);
 void add_timer(struct timer_list *timer)
 {
 	BUG_ON(timer_pending(timer));
+	timer_stats_timer_set_start_info(timer);
 	mod_timer(timer, timer->expires);
 }
 EXPORT_SYMBOL(add_timer);
-- 
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/