linux-kernel - Re: [lm-sensors] [Patch-next] therm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C7B64A8.2030208@np.css.fujitsu.com>
Date:	Mon, 30 Aug 2010 16:58:32 +0900
From:	Jin Dongming <jin.dongming@...css.fujitsu.com>
To:	Jean Delvare <khali@...ux-fr.org>
CC:	Fenghua Yu <fenghua.yu@...el.com>,
	"Brown, Len" <len.brown@...el.com>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	"H. Peter Anvin" <hpa@...ux.jf.intel.com>,
	LKLM <linux-kernel@...r.kernel.org>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>,
	mingo Redhat <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [lm-sensors] [Patch-next] therm_throt.c: fix missing { and }.

(2010/08/27 22:20), Jean Delvare wrote:
> On Thu, 26 Aug 2010 17:29:05 +0900, Jin Dongming wrote:
>> When the feature PTS is not supported by CPU, the sysfile
>> package_power_limit_count for package should not be generated.
>>
>> This patch is used for fixing missing { and }. But I have not confirmed
>> this patch because I don't have such machine.
>>
>> Signed-off-by: Jin Dongming <jin.dongming@...css.fujitsu.com>
>> ---
>>  arch/x86/kernel/cpu/mcheck/therm_throt.c |    3 ++-
>>  1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
>> index d9368ee..169d880 100644
>> --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
>> +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
>> @@ -216,7 +216,7 @@ static __cpuinit int thermal_throttle_add_dev(struct sys_device *sys_dev,
>>  		err = sysfs_add_file_to_group(&sys_dev->kobj,
>>  					      &attr_core_power_limit_count.attr,
>>  					      thermal_attr_group.name);
>> -	if (cpu_has(c, X86_FEATURE_PTS))
>> +	if (cpu_has(c, X86_FEATURE_PTS)) {
>>  		err = sysfs_add_file_to_group(&sys_dev->kobj,
>>  					      &attr_package_throttle_count.attr,
>>  					      thermal_attr_group.name);
>> @@ -224,6 +224,7 @@ static __cpuinit int thermal_throttle_add_dev(struct sys_device *sys_dev,
>>  			err = sysfs_add_file_to_group(&sys_dev->kobj,
>>  					&attr_package_power_limit_count.attr,
>>  					thermal_attr_group.name);
>> +	}
>>  
>>  	return err;
>>  }
> 
> This is incomplete. Error handling in this function is totally broken.
> 
> 
I am sorry for replying late.

Yes. What you thought is right.
But this patch is only used for fixing the problem that when the feature PTS is not
supported by CPU, the sysfile package_power_limit_count should not be generated.

So the patch for error handling should be provided as another one. I will make
a patch for it .

Thanks.

Best Regards,
Jin Dongming

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/