linux-kernel - Re: [PATCH v2 2/2] compaction: fix COMPACTPAGEFAILED counting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100830095623.GH19556@csn.ul.ie>
Date:	Mon, 30 Aug 2010 10:56:23 +0100
From:	Mel Gorman <mel@....ul.ie>
To:	Minchan Kim <minchan.kim@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel List <linux-kernel@...r.kernel.org>,
	linux-mm@...ck.org, Wu Fengguang <fengguang.wu@...el.com>,
	Hugh Dickins <hughd@...gle.com>,
	Andi Kleen <andi@...stfloor.org>,
	Christoph Lameter <cl@...ux.com>
Subject: Re: [PATCH v2 2/2] compaction: fix COMPACTPAGEFAILED counting

On Wed, Aug 25, 2010 at 12:43:40AM +0900, Minchan Kim wrote:
> Now update_nr_listpages doesn't have a role. That's because
> lists passed is always empty just after calling migrate_pages.
> The migrate_pages cleans up page list which have failed to migrate
> before returning by aaa994b3.
> 
>  [PATCH] page migration: handle freeing of pages in migrate_pages()
> 
>  Do not leave pages on the lists passed to migrate_pages().  Seems that we will
>  not need any postprocessing of pages.  This will simplify the handling of
>  pages by the callers of migrate_pages().
> 
> At that time, we thought we don't need any postprocessing of pages.
> But the situation is changed. The compaction need to know the number of
> failed to migrate for COMPACTPAGEFAILED stat
> 
> This patch makes new rule for caller of migrate_pages to call putback_lru_pages.
> So caller need to clean up the lists so it has a chance to postprocess the pages.
> [suggested by Christoph Lameter]
> 
> Cc: Hugh Dickins <hughd@...gle.com>
> Cc: Andi Kleen <andi@...stfloor.org>
> Cc: Christoph Lameter <cl@...ux.com>
> Cc: Mel Gorman <mel@....ul.ie>
> Signed-off-by: Minchan Kim <minchan.kim@...il.com>

Looks good and it passed basic testing.

Reviewed-by: Mel Gorman <mel@....ul.ie>

Thanks

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/