linux-kernel - RE: [PATCH 1/3] ARM: Samsung S5P: Move the common Samsung S5P series GPIO level type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <006201cb483b$0e1727e0$2a4577a0$%kim@samsung.com>
Date:	Mon, 30 Aug 2010 21:01:15 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Kyungmin Park' <kmpark@...radead.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:	jy0922.shim@...sung.com, m.szyprowski@...sung.com,
	ben-linux@...ff.org
Subject: RE: [PATCH 1/3] ARM: Samsung S5P: Move the common Samsung S5P series
	GPIO level type

Kyungmin Park wrote:
> 
> From: Kyungmin Park <kyungmin.park@...sung.com>
> 
> Samsung S5P series has common level type. It's different from S3C series.
> 
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> ---
>  arch/arm/plat-samsung/include/plat/gpio-core.h |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/plat-samsung/include/plat/gpio-core.h
b/arch/arm/plat-
> samsung/include/plat/gpio-core.h
> index e358c7d..c8681e0 100644
> --- a/arch/arm/plat-samsung/include/plat/gpio-core.h
> +++ b/arch/arm/plat-samsung/include/plat/gpio-core.h
> @@ -14,6 +14,12 @@
>  #define GPIOCON_OFF	(0x00)
>  #define GPIODAT_OFF	(0x04)
> 
> +#define S5P_GPIO_LEVEL_LOW		(0x00)
> +#define S5P_GPIO_LEVEL_HIGH		(0x01)
> +#define S5P_GPIO_EDGE_FALLING		(0x02)
> +#define S5P_GPIO_EDGE_RISING		(0x03)
> +#define S5P_GPIO_EDGE_BOTH		(0x04)

Why should we change the name of definition from S5P_EXTINT_XXX?
If we use that, we don't need to change other files.

> +
>  #define con_4bit_shift(__off) ((__off) * 4)
> 
>  /* Define the core gpiolib support functions that the s3c platforms may
> --

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/