linux-kernel - Re: [PATCH v2] input: Add support for Hanwang tablet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100830163446.GB17325@core.coreip.homeip.net>
Date:	Mon, 30 Aug 2010 09:34:46 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Xing Wei <weixing@...wang.com.cn>
Cc:	jkosina <jkosina@...e.cz>,
	linux-input <linux-input@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] input: Add support for Hanwang tablet

On Mon, Aug 30, 2010 at 09:33:12PM +0800, Xing Wei wrote:
> On Mon, 30 Aug 2010, Jiri Kosina Wrote: 
> > > On Mon, 30 Aug 2010, Xing Wei wrote:
> > >  
> > > +config TABLET_USB_HANWANG
> > > +	tristate "Hanwang Art Master III tablet support (USB)"
> > > +	depends on USB_ARCH_HAS_HCD
> > > +	select USB
> > > +	help
> > > +	  Say Y here if you want to use the USB version of the Hanwang Art
> > > +	  Master III tablet.  Make sure to say Y to "Mouse support"
> > > +	  (CONFIG_INPUT_MOUSEDEV) and/or "Event interface support"
> > > +	  (CONFIG_INPUT_EVDEV) as well.
> > 
> > Is there any reason why you don't have these (MOUSEDEV and EVDEV) as 
> > explicit Kconfig dependencies?
> > 
> > Thanks,
> > 
> 
> I just reference the other USB tablet on this Kconfig,like aiptek,acecad,wacom.
> Actually it depends on EVDEV at least now.
> I can submit another patch if necessarry.
> 

Actually I think we should just drop references to particular input
handlers in the Kconfig as, strictly speaking, the driver does not
depend on either of them.

The text in other tablets came from time when whole input layer was a
novelty and nobody was sure what should be enabled. Nowadays every
distribution (I hope) has evdev enabled as it becomes main interface
between X and kernel and the legacy mouse and keyboard interfaces
(MOUSEDEV) are fading away.

While we are talking about the patch - I am usually OK with extending past
80 column limit, but some of the lines are pretty excessive. I'd prefer
not going above 95-100 unless it is a message string - we do not want to
break those.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/