linux-kernel - Re: TRACE: config warning for IRQSOFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 30 Aug 2010 20:47:33 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Richard Kennedy <richard@....demon.co.uk>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	lkml <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: TRACE: config warning for IRQSOFF_TRACER

On Sat, 2010-08-21 at 15:52 +0100, Richard Kennedy wrote: 
> In my config with PROVE_LOCKING=n and FTRACE=y (which defaults
> IRQSOFF_TRACER to y), I get the following warning from make oldconfig.
> 
> scripts/kconfig/conf --oldconfig arch/x86/Kconfig
> warning: (IRQSOFF_TRACER && TRACING_SUPPORT && FTRACE &&
> TRACE_IRQFLAGS_SUPPORT && !ARCH_USES_GETTIMEOFFSET) selects
> TRACE_IRQFLAGS which has unmet direct dependencies (DEBUG_KERNEL &&
> TRACE_IRQFLAGS_SUPPORT && PROVE_LOCKING)
> 
> The problem is that TRACE_IRQFLAGS depends on PROVE_LOCKING.
> Should it select PROVE_LOCKING instead? or is there a better way to fix
> this?

The TRACE_IRQFLAGS was originally written for lockdep, but it is now
used by Ftrace's irqsoff tracer.

I just compiled and booted with TRACE_IRQFLAGS=y and PROVE_LOCKING not
set, and it worked fine.

I think the correct patch is to remove the dependency of TRACE_IRQFLAGS
on PROVE_LOCKING.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/