linux-kernel - Re: [PATCH 1/3] drivers: misc: ak8974 / ami305 magnetometer driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikd8pCCn6aYL610qcUAHWsj5zoU8UBJ1pf4ffe1@mail.gmail.com>
Date:	Tue, 31 Aug 2010 12:43:16 +0530
From:	Sundar <sunder.svit@...il.com>
To:	samu.p.onkalo@...ia.com
Cc:	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/3] drivers: misc: ak8974 / ami305 magnetometer driver

Hi again,

On Mon, Aug 30, 2010 at 12:42 PM, Onkalo Samu <samu.p.onkalo@...ia.com> wrote:
>
> It would require some more operations since the chip would loose its
> state totally. But yes, it could be done.
>
Yes. Something like re-programming the context. but it would make sure that
the module draws no power at all.

Also, would it not be correct to include a cancel_work_sync in case of
return here?

+fail4:
+       misc_deregister(&chip->miscdev);
+fail3:
+       ak8974_regulators_off(chip);
+fail2:
+       regulator_bulk_free(ARRAY_SIZE(chip->regs), chip->regs);
+fail1:
+       kfree(chip);
+       return err;
+}

Cheers!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/