linux-kernel - Re: [PATCH net-next-2.6] net/ipv4: push IP options to CB in ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1283246271.2550.35.camel@edumazet-laptop>
Date:	Tue, 31 Aug 2010 11:17:51 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Bandan Das <bandan.das@...atus.com>,
	David Miller <davem@...emloft.net>,
	NetDev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Patrick McHardy <kaber@...sh.net>
Subject: Re: [PATCH net-next-2.6] net/ipv4: push IP options to CB in
 ip_fragment

Le mardi 31 août 2010 à 16:24 +0800, Herbert Xu a écrit :
> On Tue, Aug 31, 2010 at 07:20:31AM +0200, Eric Dumazet wrote:
> > Le lundi 30 août 2010 à 19:21 -0400, Bandan Das a écrit :
> > > > 
> > > > I wonder if we want this.
> > > > 
> > > > Maybe setting skb->local_df = 1 in bridge should be enough ?
> > > > 
> > > > 
> > > Thanks Eric for looking at this. Indeed, setting local_df to 1 seems to be enough! I will
> > > respin and post a different patch.
> > > 
> > 
> > Reading this stuff again, I wonder if we should not revert commit
> > 17762060c25590bfddd  and use a different trick
> 
> I don't quite understand the problem.  Does the packet actually
> have IP options? If not why is it trying to look at IP options?
> 
> If it does have options, then we should parse options in the
> bridge driver before passing it to the IP stack (or just drop
> the packet).

Once again, the IP stack -> bridge -> IP stack flow bites us,
because bridge likes to dirty IPCB.

We can correct every bug we find once in a while (you did in commit
17762060c255 for a particular bug), or just make bridge not touch IPCB.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/