linux-kernel - Re: [PATCH 1/2] msm: Install the Google-Android gpio driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1283273418.11790.3.camel@c-dwalke-linux.qualcomm.com>
Date:	Tue, 31 Aug 2010 09:50:18 -0700
From:	Daniel Walker <dwalker@...eaurora.org>
To:	Gregory Bean <gbean@...eaurora.org>
Cc:	linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Arve Hjønnevåg <arve@...roid.com>
Subject: Re: [PATCH 1/2] msm: Install the Google-Android gpio driver.

On Mon, 2010-08-30 at 17:18 -0700, Gregory Bean wrote:
> +                       /* printk("%s %08x %08x bit %d gpio %d irq %d\n",
> +                               __func__, v, m, j, msm_chip->chip.start + j,
> +                               FIRST_GPIO_IRQ + msm_chip->chip.start + j); */
> 

Can you drop everything that's un-used .. There's also the enter/exit
sleep functions, which I'm pretty sure aren't used. Also break this into
two patches one for gpio and another for the interrupt component ..

Daniel

-- 

Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/