linux-kernel - Re: [Patch-next -v2]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100831173022.GB30454@fenghua-desk.sc.intel.com>
Date:	Tue, 31 Aug 2010 10:30:23 -0700
From:	Fenghua Yu <fenghua.yu@...el.com>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	Jin Dongming <jin.dongming@...css.fujitsu.com>,
	"Yu, Fenghua" <fenghua.yu@...el.com>,
	"Brown, Len" <len.brown@...el.com>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	LKLM <linux-kernel@...r.kernel.org>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>,
	mingo Redhat <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...ux.jf.intel.com>
Subject: Re: [Patch-next -v2]therm_throt.c: Trival fix for a unsuitable
	abbreviation  of thermal.

On Mon, Aug 30, 2010 at 11:56:53PM -0700, Jean Delvare wrote:
> On Tue, 31 Aug 2010 09:13:33 +0900, Jin Dongming wrote:
> > In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
> > in error message.
> > 
> > I don't think TMR is a suitable abbreviation for thermal.
> >   1.TMR has been used in IA32 Architectures Software Developer's
> >     Manual, and is the abbreviation for Trigger Mode Register.
> >   2.There is not an standard abbreviation "TMR" defined for thermal
> >     in IA32 Architectures Software Developer's Manual.
> >   3.Though we could understand it as Thermal Monitor Register, it is
> >     easy to be misunderstood as a *TIMER* interrupt also.
> > 
> > I think this patch will fix it.
> > 
> > Signed-off-by: Jin Dongming <jin.dongming@...css.fujitsu.com>
> 
> Reviewed-by: Jean Delvare <khali@...ux-fr.org>
 Reviewed-by: Fenghua Yu <fenghua.yu@...el.com>
> 
> > ---
> >  arch/x86/kernel/cpu/mcheck/therm_throt.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> > index d9368ee..ba52598 100644
> > --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
> > +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> > @@ -349,7 +349,7 @@ static void intel_thermal_interrupt(void)
> >  
> >  static void unexpected_thermal_interrupt(void)
> >  {
> > -	printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
> > +	printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
> >  			smp_processor_id());
> >  	add_taint(TAINT_MACHINE_CHECK);
> >  }
> 
> 
> -- 
> Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/