linux-kernel - Re: [PATCH] Staging: crystalhd: crystalhd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100831220506.GA21191@kroah.com>
Date:	Tue, 31 Aug 2010 15:05:06 -0700
From:	Greg KH <greg@...ah.com>
To:	Gunnar Gudvardarson <gunni@...e.is>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: crystalhd: crystalhd_cmds: fixed a brace issue

On Wed, Aug 18, 2010 at 08:10:06PM +0000, Gunnar Gudvardarson wrote:
> Fixed a brace issue.
> 
> Signed-off-by: Gunnar Gudvardarson <gunni@...e.is>
> ---
>  drivers/staging/crystalhd/crystalhd_cmds.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/crystalhd/crystalhd_cmds.c b/drivers/staging/crystalhd/crystalhd_cmds.c
> index 1429608..d423775 100644
> --- a/drivers/staging/crystalhd/crystalhd_cmds.c
> +++ b/drivers/staging/crystalhd/crystalhd_cmds.c
> @@ -309,9 +309,9 @@ static enum BC_STATUS bc_cproc_download_fw(struct crystalhd_cmd *ctx,
>  	sts = crystalhd_download_fw(ctx->adp, (uint8_t *)idata->add_cdata,
>  				  idata->add_cdata_sz);
>  
> -	if (sts != BC_STS_SUCCESS) {
> +	if (sts != BC_STS_SUCCESS)
>  		BCMLOG_ERR("Firmware Download Failure!! - %d\n", sts);
> -	} else
> +	else

This breaks the build, are you sure you tested it after making the
patch?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/