linux-kernel - Re: [PATCH 1/8] Staging: rtl8187se: r8180: fixed alot checkpatch.pl issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100831223129.GA316@kroah.com>
Date:	Tue, 31 Aug 2010 15:31:29 -0700
From:	Greg KH <greg@...ah.com>
To:	T Dent <tdent48227@...il.com>
Cc:	linux-kernel@...r.kernel.org, bzolnier@...il.com,
	Larry.Finger@...inger.net, joe@...ches.com, pshah.mumbai@...il.com
Subject: Re: [PATCH 1/8] Staging: rtl8187se: r8180: fixed alot
 checkpatch.pl issues

On Fri, Aug 20, 2010 at 05:00:13PM -0400, T Dent wrote:
> >From 73dfcd936fcacb6f1dce184e21b177c9fa4797d5 Mon Sep 17 00:00:00 2001
> From: Tracey Dent <Tdent48227@...il.com>
> Date: Thu, 19 Aug 2010 16:13:48 -0400
> Subject: [PATCH 1/8] Staging: rtl8187se: r8180: fixed alot checkpatch.pl issues
> 
> Fixed numerous coding style issues using checkpatch.pl
> 
> Signed-off-by: Tracey Dent <tdent48227@...il.com>
> ---
>  drivers/staging/rtl8187se/r8180.h |  537 ++++++++++++++++++-------------------
>  1 files changed, 265 insertions(+), 272 deletions(-)
> 
> diff --git a/drivers/staging/rtl8187se/r8180.h
> b/drivers/staging/rtl8187se/r8180.h
> index d15bdf6..c5b1cba 100644
> --- a/drivers/staging/rtl8187se/r8180.h
> +++ b/drivers/staging/rtl8187se/r8180.h
> @@ -1,18 +1,18 @@
>  /*
> -   This is part of rtl8180 OpenSource driver.
> -   Copyright (C) Andrea Merello 2004-2005  <andreamrl@...cali.it>
> -   Released under the terms of GPL (General Public Licence)
> +	This is part of rtl8180 OpenSource driver.
> +	Copyright (C) Andrea Merello 2004-2005  <andreamrl@...cali.it>
> +	Released under the terms of GPL (General Public Licence)
> 
> -   Parts of this driver are based on the GPL part of the
> -   official realtek driver
> +	Parts of this driver are based on the GPL part of the
> +	official realtek driver
> 
> -   Parts of this driver are based on the rtl8180 driver skeleton
> -   from Patric Schenke & Andres Salomon
> +	Parts of this driver are based on the rtl8180 driver skeleton
> +	from Patric Schenke & Andres Salomon
> 
> -   Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver
> +	Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver
> 
> -   We want to tanks the Authors of those projects and the Ndiswrapper
> -   project Authors.
> +	We want to tanks the Authors of those projects and the Ndiswrapper
> +	project Authors.
>  */
> 
>  #ifndef R8180H
> @@ -20,13 +20,13 @@
> 
> 
>  #define RTL8180_MODULE_NAME "r8180"
> -#define DMESG(x,a...) printk(KERN_INFO RTL8180_MODULE_NAME ": " x "\n", ## a)
> -#define DMESGW(x,a...) printk(KERN_WARNING RTL8180_MODULE_NAME ":
> WW:" x "\n", ## a)

Your patches are line-wrapped and can't be applied :(

Care to fix your email client and resend them?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/