linux-kernel - Re: [PATCH][GIT PULL] ring-buffer: Place duplicate expression into a single function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100901171622.GE2486@tuxdriver.com>
Date:	Wed, 1 Sep 2010 13:16:22 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Neil Brown <neilb@...e.de>,
	"ksummit-2010-discuss@...ts.linux-foundation.org" 
	<ksummit-2010-discuss@...ts.linux-foundation.org>
Subject: Re: [PATCH][GIT PULL] ring-buffer: Place duplicate expression into a
 single function

On Wed, Sep 01, 2010 at 12:49:52PM -0400, Steven Rostedt wrote:
> 
> Ingo,
> 
> Please pull the latest tip/perf/core tree, which can be found at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
> tip/perf/core
> 
> 
> Steven Rostedt (1):
>       ring-buffer: Place duplicate expression into a single function
> 
> ----
>  kernel/trace/ring_buffer.c |   21 +++++++++++++++------
>  1 files changed, 15 insertions(+), 6 deletions(-)
> ---------------------------
> commit f6195aa09e618d712f52bf4fa33b5293820eb93d
> Author: Steven Rostedt <srostedt@...hat.com>
> Date:   Wed Sep 1 12:23:12 2010 -0400
> 
>     ring-buffer: Place duplicate expression into a single function
>     
>     While discussing the strictness of the 80 character limit on the
>     Kernel Summit Discussion mailing list, I showed examples that I
>     broke that limit slightly with some algorithms. In discussing with
>     John Linville, what looked better, I realized that two of the
>     80 char breaking culprits were an identical expression.
>     
>     As a clean up, this patch moves the identical expression into its
>     own helper function and that is used instead. As a side effect,
>     the offending code is now under the 80 character limit. :-)
>     
>     This clean up code also changes the expression from
>     
>     	(A - B) - C  to  A - (B + C)
>     
>     This makes the code look a little nicer too.
>     
>     Cc: John W. Linville <linville@...driver.com>
>     Signed-off-by: Steven Rostedt <rostedt@...dmis.org>

ACK :-)

-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/