linux-kernel - Re: [PATCH 2/5] staging: hv: Fixed lockup problem with bounce_buffer scatter list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C7D601B.3060708@sailtheuniverse.com>
Date:	Tue, 31 Aug 2010 13:03:39 -0700
From:	Hank Janssen <hjanssen@...ltheuniverse.com>
To:	Joe Perches <joe@...ches.com>
CC:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org, virtualization@...ts.osdl.org,
	Haiyang Zhang <haiyangz@...rosoft.com>
Subject: Re: [PATCH 2/5] staging: hv: Fixed lockup problem with bounce_buffer
 scatter list - RESEND

On 09/01/2010 09:38 AM, Joe Perches wrote:
> On Tue, 2010-08-31 at 11:13 -0700, Hank Janssen wrote:
> 
>> diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvsc_drv.c
> []
>> -			request->DataBuffer.PfnArray[i] =
>> -					page_to_pfn(sg_page((&sgl[i])));
>> +			request->DataBuffer.PfnArray[i] = 
>> +				page_to_pfn(sg_page((&sgl[i])));
> 
> I did a bit of a doubletake reading this last change.
> 
> This isn't actually a part of your fix and it introduces
> a whitespace error.
> 

I will resubmit this patch and clean up the whitespace error.

When change the code I normally also change the indentation to the
correct format for that area of the code. That is how the whitespace
snuck in there.

Thanks,

Hank.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/