linux-kernel - Re: [PATCH] [arch-x86] Allow SRAT integrity check to be skipped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41621.148.87.67.139.1283378664.squirrel@www.xenotime.net>
Date:	Wed, 1 Sep 2010 15:04:24 -0700 (PDT)
From:	rdunlap@...otime.net
To:	"Peter P Waskiewicz Jr" <peter.p.waskiewicz.jr@...el.com>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, linux-kernel@...r.kernel.org, andi@...stfloor.org,
	netdev@...r.kernel.org, peter.p.waskiewicz.jr@...el.com
Subject: Re: [PATCH] [arch-x86] Allow SRAT integrity check to be skipped

On Wed, September 1, 2010 2:33 pm, Peter P Waskiewicz Jr wrote:
> Documentation/x86/x86_64/boot-options.txt |    4 ++++
> arch/x86/mm/srat_64.c                     |   20 +++++++++++++++++--- 2
> files changed, 21 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/mm/srat_64.c b/arch/x86/mm/srat_64.c index
> f9897f7..8719472 100644 --- a/arch/x86/mm/srat_64.c
> +++ b/arch/x86/mm/srat_64.c
> @@ -351,6 +351,15 @@ int __init acpi_get_nodes(struct bootnode *physnodes)
>  return ret; }
>
>
> +int srat_bypass_bios = 0;

static int srat_bypass_bios;

Don't need to init to 0.

> +
> +static int __init srat_bypass_bios_setup(char *str)
> +{
> +        srat_bypass_bios = 1;
> +        return 0;
> +}
> +early_param("sratbypassbios", srat_bypass_bios_setup);
> +
> /* Use the information discovered above to actually set up the nodes. */
> int __init acpi_scan_nodes(unsigned long start, unsigned long end) {
> @@ -425,9 +434,14 @@ int __init acpi_scan_nodes(unsigned long start,
> unsigned long end) nodes[i].end >> PAGE_SHIFT); /* for out of order entries
> in SRAT */ sort_node_map(); -	if (!nodes_cover_memory(nodes)) {
> -		bad_srat();
> -		return -1;
> +	if (!srat_bypass_bios) {
> +		if (!nodes_cover_memory(nodes)) {
> +			bad_srat();
> +			return -1;
> +		}
> +	} else {
> +		printk(KERN_INFO
> +		           "SRAT: Bypassing NUMA sanity check...bad BIOS...\n");
> }


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/