linux-kernel - [PATCH trivial] drm: log level in print_hex_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20100901021302.GX2684@bombadil.infradead.org>
Date:	Tue, 31 Aug 2010 22:13:02 -0400
From:	Kyle McMartin <kyle@...artin.ca>
To:	airlied@...hat.com
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH trivial] drm: log level in print_hex_dump_bytes is redundant

Ends up with a dmesg like:
[drm:drm_edid_block_valid] *ERROR* Raw EDID:
<3>00 ff ff ff ff ff ff 00 10 ac 29 a0 53 48 4e 31  ..........).SHN1
<3>14 12 01 03 0e 34 20 7f ff ff ff ff ff ff ff ff  .....4 .........

Since print_hex_dump_bytes implicitly adds KERN_DEBUG.

Would probably be nice to pretty print the encoder that found the bad
EDID, but it seems in some cases another caller of drm_edid_is_valid
will do that, so probably unnecessary...

Signed-off-by: Kyle McMartin <kyle@...hat.com>
---
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 96e9631..32a167c 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -186,7 +186,7 @@ drm_edid_block_valid(u8 *raw_edid)
 bad:
 	if (raw_edid) {
 		DRM_ERROR("Raw EDID:\n");
-		print_hex_dump_bytes(KERN_ERR, DUMP_PREFIX_NONE, raw_edid, EDID_LENGTH);
+		print_hex_dump_bytes("", DUMP_PREFIX_NONE, raw_edid, EDID_LENGTH);
 		printk("\n");
 	}
 	return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/