linux-kernel - Re: [PATCH 2/4] Low-level init of hsmmc controller for LogicPD's OMAP3530LV SOM and OMAP 35x Torpedo dev boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100902132211.GF26319@n2100.arm.linux.org.uk>
Date:	Thu, 2 Sep 2010 14:22:11 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Jacob Tanenbaum <Jacob.Tanenbaum@...icpd.com>
Cc:	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4]  Low-level init of hsmmc controller for LogicPD's
	OMAP3530LV SOM and OMAP 35x Torpedo dev boards

On Tue, Aug 24, 2010 at 11:53:38PM -0400, Jacob Tanenbaum wrote:
> From: jake <jake@...dos.(none)>

Not a valid address... please fix.

> 
>     	ARM: OMAP3LOGIC: Adding SDMMC support
>              Add low-level initialization for hsmmc controller for
>              LogicPD's OMAP 3530 LV SOM and OMAP 35x Torpedo board.
> 
> 	Tested against: 81e09f50c93edff607259cbe374a3006c9c5fa74
> 	Signed-off-by: Jacob Tanenbaum <Jacob.Tanenbaum@...icpd.com>

I'm confused why these comments are indented.

> +static void __init board_mmc_init(void)
> +{
> +	/* OMAP3530 LV SOM board */
> +	if (machine_is_omap3530_lv_som()) {
> +		board_mmc_info[0].gpio_cd = OMAP3530_LV_SOM_MMC_GPIO_CD;
> +		board_mmc_info[0].gpio_wp = OMAP3530_LV_SOM_MMC_GPIO_WP;
> +		omap_mux_init_signal("gpio_110", OMAP_PIN_OUTPUT);
> +		omap_mux_init_signal("gpio_126", OMAP_PIN_OUTPUT);
> +
> +
> +	/* OMAP3 Torpedo board */

missing tab?

> +	} else if (machine_is_omap3_torpedo()) {
> +		board_mmc_info[0].gpio_cd = OMAP3_TORPEDO_MMC_GPIO_CD;
> +		omap_mux_init_signal("gpio_127", OMAP_PIN_OUTPUT);
> +	/* unsupported board */

missing tab?

> +	} else {
> +		printk(KERN_ERR "%s(): unknown machine type\n", __func__);
> +	return;

missing tab?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/