linux-kernel - Re: [PATCH 3/3] dmaengine: Add Freescale i.MX SDMA support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 Sep 2010 15:06:30 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Linus Walleij <linus.ml.walleij@...il.com>
Cc:	Sascha Hauer <s.hauer@...gutronix.de>,
	Dan Williams <dan.j.williams@...el.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/3] dmaengine: Add Freescale i.MX SDMA support

On Mon, Aug 16, 2010 at 02:21:06PM +0200, Linus Walleij wrote:
> > +/*
> > + * Buffer descriptor
> > + */
> > +struct sdma_buffer_descriptor {
> > +       struct sdma_mode_count  mode;
> > +       u32 buffer_addr;    /* address of the buffer described */
> > +       u32 ext_buffer_addr; /* extended buffer address */
> 
> Shouldn't these be dma_addr_t? OK that's probably u32
> anyway but just to make a marker...

If this is describing hardware, then it makes sense to use uNN rather
than dma_addr_t.  dma_addr_t may be subject to change in the future.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/