linux-kernel - Re: [PATCH v2] vmscan: prevent background aging of anon page in no swap system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTikWok_3ANHuxVs=muTVKi3AbcQTphxAfBT613u2@mail.gmail.com>
Date:	Fri, 3 Sep 2010 00:34:03 +0900
From:	Minchan Kim <minchan.kim@...il.com>
To:	Rik van Riel <riel@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ying Han <yinghan@...gle.com>, linux-mm <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Johannes Weiner <hannes@...xchg.org>
Subject: Re: [PATCH v2] vmscan: prevent background aging of anon page in no
 swap system

Will fix.
Thanks for the quick response. Rik.

On Fri, Sep 3, 2010 at 12:16 AM, Rik van Riel <riel@...hat.com> wrote:
> On 09/02/2010 11:12 AM, Minchan Kim wrote:
>
>> +       /*
>> +        * If we don't have enough swap space, anonymous page deactivation
>> +        * is pointless.
>> +        */
>> +       if (!nr_swap_pages)
>> +               return 0;
>
> It may be better to test !total_swap_pages and change the
> comment to:
>
>        /*
>         * If we don't have swap space, anonymous page deactivation
>         * is pointless.
>         */
>
> --
> All rights reversed
>



-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/