linux-kernel - Re: [PATCH] identify firmware version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C7FE63F.5010709@seas.upenn.edu>
Date:	Thu, 02 Sep 2010 14:00:31 -0400
From:	Rafi Rubin <rafi@...s.upenn.edu>
To:	Jiri Slaby <jirislaby@...il.com>
CC:	dmitry.torokhov@...il.com, jkosina@...e.cz,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	micki@...rig.com, rydberg@...omail.se, chatty@...c.fr
Subject: Re: [PATCH] identify firmware version

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/02/10 04:03, Jiri Slaby wrote:
> On 09/02/2010 02:12 AM, Rafi Rubin wrote:
>>
>>
>> On 09/01/2010 04:12 PM, Jiri Slaby wrote:
>>> On 09/01/2010 11:48 AM, Rafi Rubin wrote:
>>>> --- a/drivers/hid/hid-ntrig.c
>>>> +++ b/drivers/hid/hid-ntrig.c
>>>> @@ -90,6 +90,26 @@ struct ntrig_data {
>>>>   };
>>>>
>>>>
>>>> +/*
>>>> + * This function converts the 4 byte raw firmware code into
>>>> + * a string containing 5 comma separated numbers.
>>>> + */
>>>> +static int ntrig_version_string(unsigned char *raw, char *buf)
>>>> +{
>>>> +    __u8 a =  (raw[1]&  0b00001110)>>  1;
>>>> +    __u8 b =  (raw[0]&  0b00111100)>>  2;
>>>> +    __u8 c = ((raw[0]&  0b00000011)<<  3) | ((raw[3]& 
>>>> 0b11100000)>>  5);
>>>> +    __u8 d = ((raw[3]&  0b00000111)<<  3) | ((raw[2]& 
>>>> 0b11100000)>>  5);
>>>> +    __u8 e =   raw[2]&  0b00000111;
>>>
>>> This won't compile with gcc 3.4 which we still support. Maybe time to
>>> kill the support?
>>>
>>> ...
>>
>> Why not?
> 
> Beacuse it's a gnu extension added in gcc 4.3. (I though it's in gcc 4.0
> initially, but it's not. So you cannot use it in the kernel code at all.)

Sorry, would you please clarify "it".  Which bit of syntax in that code is
unsupported by the older versions of gcc?

Rafi
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkx/5j8ACgkQwuRiAT9o60/uiACfTJkcLG/0m/4WQpBi82ugunc3
WY4AoIpJglKNJRm4ST1VP5nE+AiMAMJ0
=k6/0
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/