[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4C800266.1000005@oracle.com>
Date: Thu, 02 Sep 2010 13:00:38 -0700
From: Randy Dunlap <randy.dunlap@...cle.com>
To: Lucas De Marchi <lucas.de.marchi@...il.com>
CC: linux-kernel@...r.kernel.org
Subject: Re: [RFC] Fix typos
On 09/02/10 12:31, Lucas De Marchi wrote:
> On Thu, Sep 2, 2010 at 16:18, Randy Dunlap <randy.dunlap@...cle.com> wrote:
>> Hi,
>>
>> I'd take most of the corrections in Documentation/, but in general,
>> I don't think that it's a good idea without some careful review.
>
> I plan to review it if it's indeed worth fixing those typos. I already
> fixed several false positives like "rela" being changed to "real",
> but since it's a 1.8 MB patch I think it's better to ask first before
> making any other review.
>
>>
>> E.g.:
>>
>> 1. changing thru to through isn't needed IMO.
>> Can you add "thru" to your dictionary?
> Yes, no problem
>
>>
>> 2.
>> -(Warning, pulses on ACK ar inverted by transistor, irq is rised up on sync
>> +(Warning, pulses on ACK ar inverted by transistor, irq is rose up on sync
>>
> Humn.. indeed this seems to be a bad typo in my dictionary.
>
>> I'm not so sure about "is rose up" being better. and what about "ar"?
>
> I'm only changing words with 3 chars or more, because otherwise I
> would have a lot of false positives, but I think I can add this word
> without much trouble.
>
Mike's suggested change is good here.
>>
>> I saw a few others that I could comment on, but I lost them in the 1.8 MB patch file.
>
> If you say it's good, I can review it more carefully.
It looks good for Documentation/.
And fixing typos is certainly something that we want to do in
user-visible messages, like printk strings.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists