linux-kernel - Re: Resend: [PATCH] x86-64: fix unwind annotations in syscall stubs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 03 Sep 2010 00:49:35 +0200
From:	"Alexander van Heukelum" <heukelum@...tmail.fm>
To:	"Jan Beulich" <JBeulich@...ell.com>, "Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Resend: [PATCH] x86-64: fix unwind annotations in syscall  stubs

On Thu, 02 Sep 2010 13:52 +0100, "Jan Beulich" <JBeulich@...ell.com> wrote:
> With the return address removed from the stack, these should really
> refer to their caller's register state.
> 
> Signed-off-by: Jan Beulich <jbeulich@...ell.com>
> 
> ---
>  arch/x86/kernel/entry_64.S |    7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> --- linux-2.6.36-rc3/arch/x86/kernel/entry_64.S
> +++ 2.6.36-rc3-x86_64-stub-unwind-annotations/arch/x86/kernel/entry_64.S
> @@ -714,9 +714,8 @@ END(ptregscall_common)
>  
>  ENTRY(stub_execve)
>  	CFI_STARTPROC
> -       popq %r11
> -       CFI_ADJUST_CFA_OFFSET -8
> -       CFI_REGISTER rip, r11
> +       addq $8, %rsp
> +       PARTIAL_FRAME 0
>  	SAVE_REST
>  	FIXUP_TOP_OF_STACK %r11
>  	movq %rsp, %rcx
> @@ -735,7 +734,7 @@ END(stub_execve)
>  ENTRY(stub_rt_sigreturn)
>  	CFI_STARTPROC
>  	addq $8, %rsp
> -       CFI_ADJUST_CFA_OFFSET   -8
> +       PARTIAL_FRAME 0
>  	SAVE_REST
>  	movq %rsp,%rdi
>  	FIXUP_TOP_OF_STACK %r11
> 

Thanks for creating these...

Acked-by: Alexander van Heukelum <heukelum@...tmail.fm>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/