linux-kernel - Re: [PATCH 3/3] Fix M68K irqflags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7077.1283496259@redhat.com>
Date:	Fri, 03 Sep 2010 07:44:19 +0100
From:	David Howells <dhowells@...hat.com>
To:	Greg Ungerer <gerg@...pgear.com>
Cc:	dhowells@...hat.com, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] Fix M68K irqflags

Greg Ungerer <gerg@...pgear.com> wrote:

> >  -	DEFINE(THREAD_SIZE, THREAD_SIZE);
> > -
> 
> This breaks final link due to missing THREAD_SIZE definition in head.S:
> 
>   LD      vmlinux
> arch/m68knommu/platform/coldfire/head.o: In function `_clear_bss':
> (.head.text+0xa4): undefined reference to `THREAD_SIZE'
> 
> 
> Without that asm-offsets.c change it works on my ColdFire boards.
> I am happy with it:

With that, I get a duplicate reference to THREAD_SIZE.  head.S should include
asm/thread_info.h rather than THREAD_SIZE being redefined in asm-offsets.

  CC      init/do_mounts_rd.o
In file included from /warthog/nfs/linux-2.6-fscache/arch/m68k/include/asm/asm-offsets.h:1,
                 from arch/m68knommu/platform/coldfire/entry.S:36:
include/generated/asm-offsets.h:46:1: warning: "THREAD_SIZE" redefined
In file included from /warthog/nfs/linux-2.6-fscache/arch/m68k/include/asm/thread_info.h:2,
                 from arch/m68knommu/platform/coldfire/entry.S:32:
/warthog/nfs/linux-2.6-fscache/arch/m68k/include/asm/thread_info_no.h:27:1: warning: this is the location of the previous definition

Unfortunately, I don't have a binutils that can handle the funny Coldfire
instructions.  Can you point me at a Coldfire toolchain?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/