linux-kernel - Re: [PATCH 1/2] Input: stmpe-ts - remove input_free_device() in stmpe_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinE4G0TYSn=hmqVxXVAbTZ1cpOAXmhqg6QGY5dP@mail.gmail.com>
Date:	Fri, 3 Sep 2010 09:13:30 +0200
From:	Luotao Fu <devtty0@...il.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Luotao Fu <l.fu@...gutronix.de>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org
Subject: Re: [PATCH 1/2] Input: stmpe-ts - remove input_free_device() in stmpe_ts_remove()

Hi,

On Fri, Sep 3, 2010 at 3:30 AM, Axel Lin <axel.lin@...il.com> wrote:
> No need to call input_free_device() after input_unregister_device().
>

yeah right. The device is input_unregister_device unregisters the
device already. Thx for fixing this.

Acked-by: Luotao Fu <devtty0@...il.com>

> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/input/touchscreen/stmpe-ts.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
> index 656148e..0339d1d 100644
> --- a/drivers/input/touchscreen/stmpe-ts.c
> +++ b/drivers/input/touchscreen/stmpe-ts.c
> @@ -361,7 +361,6 @@ static int __devexit stmpe_ts_remove(struct platform_device *pdev)
>        platform_set_drvdata(pdev, NULL);
>
>        input_unregister_device(ts->idev);
> -       input_free_device(ts->idev);
>
>        kfree(ts);
>
> --
> 1.7.2
>
>
>
>

cheers
Luotao Fu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/