linux-kernel - Re: [PATCH] perf, x86: Disable perf if the BIOS got its grubby paws on the PMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100903143258.GB373@auslistsprd01.us.dell.com>
Date:	Fri, 3 Sep 2010 09:32:58 -0500
From:	Matt Domsch <Matt_Domsch@...l.com>
To:	Arjan van de Ven <arjan@...ux.intel.com>
Cc:	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...e.hu>,
	Stephane Eranian <eranian@...gle.com>,
	"robert.richter" <robert.richter@....com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...ux.kernel.org>
Subject: Re: [PATCH] perf, x86: Disable perf if the BIOS got its grubby paws on the PMU

On Fri, Sep 03, 2010 at 06:53:59AM -0700, Arjan van de Ven wrote:
> On 9/3/2010 2:13 AM, Peter Zijlstra wrote:
> >
> >+static void print_BIOS_fail(void)
> >+{
> >+	printk(KERN_ERR "\n");
> >+	printk(KERN_ERR "=============================================\n");
> >+	printk(KERN_ERR "It appears the BIOS is actively using the PMU\n");
> >+	printk(KERN_ERR "this avoids Linux from using it, please de-  \n");
> >+	printk(KERN_ERR "activate this BIOS feature or request a BIOS \n");
> >+	printk(KERN_ERR "update from your vendor.                     \n");
> >+	printk(KERN_ERR "=============================================\n");
> >+
> >+	memset(&x86_pmu, 0, sizeof(x86_pmu));
> >+}
> >+
> >   
> 
> 
> tell us how you really feel :-)
> 
> do you want to add a phone number of the support line of the vendor 
> (based on DMI data of course) ?

I must object to messages that repeatedly (at least on every boot)
tell system administrators to contact their hardware vendor's support
lines, when it's not clear what the BIOS is doing is incorrect.  There
are plenty of valid reasons why BIOS itself would use PMU counters.
Dell PowerEdge server power management, handled by the BIOS, certainly
does use one.

My understanding is that there is a mechanism for the OS to request
BIOS to release use of PMU counters.  Are we doing that?  If BIOS does
not release the counters when asked, ok, that's something to
(potentially) warn about.  But blanket "BIOS is using a CPU feature!
Bad BIOS!  No treat for you!" - that's not helpful to anyone.

Thanks,
Matt

-- 
Matt Domsch
Technology Strategist
Dell | Office of the CTO
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/