linux-kernel - Re: dlm: Don't send callback to node making lock request when "try 1cb" fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100903151324.GB28819@redhat.com>
Date:	Fri, 3 Sep 2010 11:13:24 -0400
From:	David Teigland <teigland@...hat.com>
To:	Steven Whitehouse <swhiteho@...hat.com>
Cc:	cluster-devel@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: dlm: Don't send callback to node making lock request when "try
 1cb" fails

On Fri, Sep 03, 2010 at 10:40:16AM +0100, Steven Whitehouse wrote:
> 
> When converting a lock, an lkb is in the granted state and also being used
> to request a new state. In the case that the conversion was a "try 1cb"
> type which has failed, and if the new state was incompatible with the old
> state, a callback was being generated to the requesting node. This is
> incorrect as callbacks should only be sent to all the other nodes holding
> blocking locks. The requesting node should receive the normal (failed)
> response to its "try 1cb" conversion request only.
> 
> This was discovered while debugging a performance problem on GFS2, however
> this fix also speeds up GFS as well. In the GFS2 case the performance gain
> is over 10x for cases of write activity to an inode whose glock is cached
> on another, idle (wrt that glock) node.

Thanks, I added a comment and queued it up.
Dave


>From 314dd2a05340fffbe217c5e40ec6c3bd1d07bf89 Mon Sep 17 00:00:00 2001
From: Steven Whitehouse <swhiteho@...hat.com>
Date: Fri, 3 Sep 2010 10:07:48 -0500
Subject: [PATCH] dlm: Don't send callback to node making lock request when "try 1cb" fails

When converting a lock, an lkb is in the granted state and also being used
to request a new state. In the case that the conversion was a "try 1cb"
type which has failed, and if the new state was incompatible with the old
state, a callback was being generated to the requesting node. This is
incorrect as callbacks should only be sent to all the other nodes holding
blocking locks. The requesting node should receive the normal (failed)
response to its "try 1cb" conversion request only.

This was discovered while debugging a performance problem on GFS2, however
this fix also speeds up GFS as well. In the GFS2 case the performance gain
is over 10x for cases of write activity to an inode whose glock is cached
on another, idle (wrt that glock) node.

(comment added, dct)

Signed-off-by: Steven Whitehouse <swhiteho@...hat.com>
Tested-by: Abhijith Das <adas@...hat.com>
Signed-off-by: David Teigland <teigland@...hat.com>
---
 fs/dlm/lock.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 031dbe3..64e5f3e 100644
--- a/fs/dlm/lock.c
+++ b/fs/dlm/lock.c
@@ -1846,6 +1846,9 @@ static void send_bast_queue(struct dlm_rsb *r, struct list_head *head,
 	struct dlm_lkb *gr;
 
 	list_for_each_entry(gr, head, lkb_statequeue) {
+		/* skip self when sending basts to convertqueue */
+		if (gr == lkb)
+			continue;
 		if (gr->lkb_bastfn && modes_require_bast(gr, lkb)) {
 			queue_bast(r, gr, lkb->lkb_rqmode);
 			gr->lkb_highbast = lkb->lkb_rqmode;
-- 
1.7.1.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/