linux-kernel - [PATCH 3/3] AGP: Warn when GATT memory cannot be set to UC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1283531981-7495-4-git-send-email-bp@amd64.org>
Date:	Fri,  3 Sep 2010 18:39:41 +0200
From:	Borislav Petkov <bp@...64.org>
To:	Dave Airlie <airlied@...hat.com>, <hpa@...or.com>, <mingo@...e.hu>,
	<tglx@...utronix.de>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Cc:	<akpm@...ux-foundation.org>, <x86@...nel.org>,
	<linux-kernel@...r.kernel.org>,
	Borislav Petkov <borislav.petkov@....com>
Subject: [PATCH 3/3] AGP: Warn when GATT memory cannot be set to UC

From: Borislav Petkov <borislav.petkov@....com>

This is one of those paranoid checks which should at least tell us that
something is about to go haywire after we've disabled GART table walk
probes which is done by default now on AMD.

Signed-off-by: Borislav Petkov <borislav.petkov@....com>
---
 drivers/char/agp/generic.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/char/agp/generic.c b/drivers/char/agp/generic.c
index d2abf51..64255ce 100644
--- a/drivers/char/agp/generic.c
+++ b/drivers/char/agp/generic.c
@@ -984,7 +984,9 @@ int agp_generic_create_gatt_table(struct agp_bridge_data *bridge)
 
 	bridge->driver->cache_flush();
 #ifdef CONFIG_X86
-	set_memory_uc((unsigned long)table, 1 << page_order);
+	if (set_memory_uc((unsigned long)table, 1 << page_order))
+		printk(KERN_WARNING "Could not set GATT table memory to UC!");
+
 	bridge->gatt_table = (void *)table;
 #else
 	bridge->gatt_table = ioremap_nocache(virt_to_phys(table),
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/