linux-kernel - Re: [PATCH] binfmt_misc: Fix binfmt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100903142003.b6f02a0c.akpm@linux-foundation.org>
Date:	Fri, 3 Sep 2010 14:20:03 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jan Sembera <jsembera@...e.cz>
Cc:	linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk,
	ink@...assic.park.msu.ru, stable@...nel.org,
	linux-ia64@...r.kernel.org, "Luck, Tony" <tony.luck@...el.com>
Subject: Re: [PATCH] binfmt_misc: Fix binfmt_misc priority


(cc stable@...nel.org and the ia64 d00ds)

On Mon, 23 Aug 2010 16:15:20 +0200
Jan Sembera <jsembera@...e.cz> wrote:

> Commit 74641f584da introduced a regression - binfmt_misc is now consulted
> after binfmt_elf, which will unfortunately break ia32el. ia32 ELF binaries
> on ia64 used to be matched using binfmt_misc and executed using wrapper. As
> 32bit binaries are now matched by binfmt_elf before bindmt_misc kicks in,
> the wrapper is ignored.
> 
> The fix increases precedence of binfmt_misc to the original state.
> 
> Signed-off-by: Jan Sembera <jsembera@...e.cz>
> ---
>  fs/binfmt_misc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c
> index a7528b9..fd0cc0b 100644
> --- a/fs/binfmt_misc.c
> +++ b/fs/binfmt_misc.c
> @@ -724,7 +724,7 @@ static int __init init_misc_binfmt(void)
>  {
>  	int err = register_filesystem(&bm_fs_type);
>  	if (!err) {
> -		err = register_binfmt(&misc_format);
> +		err = insert_binfmt(&misc_format);
>  		if (err)
>  			unregister_filesystem(&bm_fs_type);
>  	}

Yikes, 74641f584da was merged in May 2009.  I wonder why this problem
wasn't noticed before now?

If we're going to change this then I guess we should change it in
2.6.36 and backport the fix as far as we can go.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/