linux-kernel - Re: [tip:x86/debug] therm_throt.c: Trival printk message fix for a unsuitable abbreviation of 'thermal'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100905185921.13c7c3f5@hyperion.delvare>
Date:	Sun, 5 Sep 2010 18:59:21 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	jin.dongming@...css.fujitsu.com, lm-sensors@...sensors.org,
	seto.hidetoshi@...fujitsu.com, fenghua.yu@...el.com,
	khali@...ux-fr.org, tglx@...utronix.de, hpa@...ux.intel.com,
	mingo@...e.hu, len.brown@...el.com
Cc:	jin.dongming@...css.fujitsu.com, linux-tip-commits@...r.kernel.org,
	linux-kernel@...r.kernel.org, hpa@...or.com,
	lm-sensors@...sensors.org, seto.hidetoshi@...fujitsu.com,
	fenghua.yu@...el.com, tglx@...utronix.de, hpa@...ux.intel.com,
	mingo@...e.hu, len.brown@...el.com
Subject: Re: [tip:x86/debug] therm_throt.c: Trival printk message fix for a
 unsuitable abbreviation of 'thermal'

6 people and 2 mailing lists Cc'd for a one-line trivial patch??

On Sun, 5 Sep 2010 13:06:45 GMT, tip-bot for Jin Dongming wrote:
> Commit-ID:  6981fe03b2055685fb6da40f54518bc6baf2b751
> Gitweb:     http://git.kernel.org/tip/6981fe03b2055685fb6da40f54518bc6baf2b751
> Author:     Jin Dongming <jin.dongming@...css.fujitsu.com>
> AuthorDate: Tue, 31 Aug 2010 09:13:33 +0900
> Committer:  Ingo Molnar <mingo@...e.hu>
> CommitDate: Sun, 5 Sep 2010 14:39:15 +0200
> 
> therm_throt.c: Trival printk message fix for a unsuitable abbreviation of 'thermal'

Typo: trivial.

> 
> In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
> in error message.
> 
> I don't think TMR is a suitable abbreviation for thermal.
>   1.TMR has been used in IA32 Architectures Software Developer's
>     Manual, and is the abbreviation for Trigger Mode Register.
>   2.There is not an standard abbreviation "TMR" defined for thermal
>     in IA32 Architectures Software Developer's Manual.
>   3.Though we could understand it as Thermal Monitor Register, it is
>     easy to be misunderstood as a *TIMER* interrupt also.
> 
> I think this patch will fix it.
> 
> Signed-off-by: Jin Dongming <jin.dongming@...css.fujitsu.com>
> Cc: Brown
> Cc: Len <len.brown@...el.com>

Something's fishy here.

> Cc: Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
> Cc: lm-sensors@...sensors.org <lm-sensors@...sensors.org>

Mailing lists shouldn't be included in Cc headers.

> Cc: H. Peter Anvin <hpa@...ux.intel.com>
> Cc: Jean Delvare <khali@...ux-fr.org>

This should read:

Reviewed-by: Jean Delvare <khali@...ux-fr.org>

> Cc: Fenghua Yu <fenghua.yu@...el.com>
> LKML-Reference: <4C7C492D.5020704@...css.fujitsu.com>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> ---
>  arch/x86/kernel/cpu/mcheck/therm_throt.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> index c2a8b26..1d0f743 100644
> --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
> +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> @@ -348,7 +348,7 @@ static void intel_thermal_interrupt(void)
>  
>  static void unexpected_thermal_interrupt(void)
>  {
> -	printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
> +	printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
>  			smp_processor_id());
>  	add_taint(TAINT_MACHINE_CHECK);
>  }


-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/