| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 5 Sep 2010 22:32:33 +0400 From: Kulikov Vasiliy <segooon@...il.com> To: kernel-janitors@...r.kernel.org Cc: Vasiliy Kulikov <segooon@...il.com>, Greg Kroah-Hartman <gregkh@...e.de>, Ian Abbott <abbotti@....co.uk>, Shawn Bohrer <shawn.bohrer@...il.com>, Mark Rankilor <reodge@...il.com>, Andrea Gelmini <andrea.gelmini@...ma.net>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: [PATCH 05/14] staging: comedi: check return code of put_user From: Vasiliy Kulikov <segooon@...il.com> Function put_user may fail. Check for it. Signed-off-by: Vasiliy Kulikov <segooon@...il.com> --- I couldn't compile this driver at all, so it is not tested. drivers/staging/comedi/comedi_fops.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index 1409131..a3c7183 100644 --- a/drivers/staging/comedi/comedi_fops.c +++ b/drivers/staging/comedi/comedi_fops.c @@ -537,7 +537,8 @@ static int do_chaninfo_ioctl(struct comedi_device *dev, x = (dev->minor << 28) | (it.subdev << 24) | (i << 16) | (s->range_table_list[i]->length); - put_user(x, it.rangelist + i); + if (put_user(x, it.rangelist + i)) + return -EFAULT; } #if 0 if (copy_to_user(it.rangelist, s->range_type_list, -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists