linux-kernel - Re: [PATCH] kbuild: fix oldnoconfig to do the right thing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100905061758.GA29547@merkur.ravnborg.org>
Date:	Sun, 5 Sep 2010 08:17:58 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Kyle McMartin <kyle@...artin.ca>
Cc:	linux-kbuild@...r.kernel.org, aris@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: fix oldnoconfig to do the right thing

On Wed, Sep 01, 2010 at 11:21:30AM -0400, Kyle McMartin wrote:
> From: Kyle McMartin <kyle@...hat.com>
> 
> Commit 861b4ea4 broke oldnoconfig when removed the oldnoconfig checks on
>                        if (input_mode == nonint_oldconfig ||
>                            input_mode == oldnoconfig) {
>                                if (input_mode == nonint_oldconfig &&
>                                    sym->name &&
>                                     !sym_is_choice_value(sym)) {
> to avoid oldnoconfig chugging through the else stanza.
> 
> Fix that to restore expected behaviour (which I've confirmed in the
> Fedora kernel build that the configs end up looking the same.)

I played aroud with this.
I looks like the only difference I got was that before
your patch oldnoconfig produced a lot of output to stdout.
With your patch is was silent.

The resulting config was the same.

We obviously want the silent variant.

Acked-by: Sam Ravnborg <sam@...nborg.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/