linux-kernel - Re: [PATCH] West Bridge Astoria Driver 2.6.35, cyasgadget fixes and mpage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100905052049.GA4371@kroah.com>
Date:	Sat, 4 Sep 2010 22:20:49 -0700
From:	Greg KH <greg@...ah.com>
To:	David Cross <david.cross@...ress.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] West Bridge Astoria Driver 2.6.35, cyasgadget fixes
	and mpage_cleardirty

On Thu, Sep 02, 2010 at 03:47:04PM -0700, David Cross wrote:
> This patch contains update to the gadget driver, some of which are based on feedback from the Linux community concerning the usage of fat_get_block.
> It also contains the addition of mpage_clear_dirty, a function used to clear dirty pages from the page cache. These two patches are also interdependent
> and difficult to separate. As such, they are included as one patch.

Please wrap your lines at 72 columns.

And is this really hard to separate?  I can't take a patch that touches
anything outside of drivers/staging/ at the moment.

How about a patch here to fix up the locking issues, and the rest as a
separate patch?

Oh, you also added lines with trailing spaces and that's it, like the
following:

> @@ -1158,10 +1145,10 @@ static int cyasgadget_ioctl(
>  			cy_as_hal_print_message("%s: fhandle is OK, "
>  				"calling vfs_getattr\n", __func__);
>  			#endif
> -
> +			
>  			ret_stat = vfs_getattr(file_to_allocate->f_path.mnt,
>  				file_to_allocate->f_path.dentry, &stat);
> -
> +			
>  			#ifndef WESTBRIDGE_NDEBUG
>  			cy_as_hal_print_message("%s: returned from "
>  				"vfs_getattr() stat->blksize=0x%lx\n",

Why?  I think you might want to make sure your editor doesn't do this in
the future.

Also, if you ran your patch through the scripts/checkpatch.pl script, it
would have caught this error.

Care to redo it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/