linux-kernel - Re: [PATCH] USB: otg: twl4030: fix phy initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c720d238d9d5ba6f483cdd7303315e4@secure211.sgcpanel.com>
Date:	Sun, 05 Sep 2010 04:51:19 -0500
From:	Felipe Balbi <me@...ipebalbi.com>
To:	Ming Lei <tom.leiming@...il.com>
Cc:	<greg@...ah.com>, <linux-usb@...r.kernel.org>,
	<linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Felipe Balbi <felipe.balbi@...ia.com>,
	Anand Gadiyar <gadiyar@...com>,
	Mike Frysinger <vapier@...too.org>,
	Sergei Shtylyov <sshtylyov@...mvista.com>
Subject: Re: [PATCH] USB: otg: twl4030: fix phy initialization

Hi,

On Sun, 5 Sep 2010 14:42:51 +0800, Ming Lei <tom.leiming@...il.com> wrote:
> issue #1:(musb device not work with cable connected with PC)
>         -twl->asleep is set as zero in .probe since bootloader has not
> powerdown phy
>         -EVENT_VBUS returned from twl4030_usb_linkstat since usb cable
> is connected with PC
>         -twl4030_phy_resume is called but does nothing since
> twl->asleep is zero
>         -the following are not called to initialize otg phy:
>                  twl4030_phy_power / twl4030_i2c_access /
>                  twl4030_usb_set_mode
>         -so musb device mode does not work

ok, I see. So what you could do is enable regulators on probe
based on PHYPWR bit.

> Sorry for disturbing you, hope you have a happy moving, :-)

np, tks :-)

> No, .asleep flag is set according to the current link state,
> instead of the initial state of transceiver. I don't think the patch
> will cause break anything. If you think it will, please describe the
> break in detail.

if we revert that patch, you'll see that usb3v1 ldos are left on
if we never plug/unplug usb cable. AFAIR, the reset state of those
LDOs is ON, so that's why we need that patch.

I'll try to work on it monday judging I'll have laptop and HW
available by then.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/