linux-kernel - Re: [PATCH] KVM: don't sent IPI if the vcpu is not online

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C84AEF5.2070309@redhat.com>
Date:	Mon, 06 Sep 2010 12:05:57 +0300
From:	Avi Kivity <avi@...hat.com>
To:	Alexander Graf <agraf@...e.de>
CC:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>, KVM <kvm@...r.kernel.org>
Subject: Re: [PATCH] KVM: don't sent IPI if the vcpu is not online

  On 09/06/2010 11:59 AM, Alexander Graf wrote:
> On 06.09.2010, at 10:55, Avi Kivity wrote:
>
>> On 09/06/2010 11:51 AM, Alexander Graf wrote:
>>>> I think guest_mode makes sense for the other archs for reducing IPIs, so let's leave it common and recommend that they implement it.  Alex, if you're ever bored.
>>> What does the bit do? Do we have documentation on it ;)? No seriously, what's the intent of the field?
>>>
>> It indicates that the vcpu is currently executing guest code.  Which in turn is important if you need to force it out of guest mode in order to inject an interrupt or flush the tlb.
> Well, a vcpu is either offline in halt state or in guest mode, no? So we can conclude that guest_mode == !offline&&  !halt_state.

It can also be running host kernel or user code.

> When in halt state, we are active on the wakeup waitqueue:
>
> static void kvmppc_decrementer_func(unsigned long data)
> {
>          struct kvm_vcpu *vcpu = (struct kvm_vcpu *)data;
>
>          kvmppc_core_queue_dec(vcpu);
>
>          if (waitqueue_active(&vcpu->wq)) {
>                  wake_up_interruptible(&vcpu->wq);
>                  vcpu->stat.halt_wakeup++;
>          }
> }
>
> Shouldn't that be enough information already?

It's sufficient for correctness.  It's not optimal since you miss the 
cases where you're not running guest code.

Not sure how important it is.  Xiao, any numbers?

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/