linux-kernel - Re: [PATCH 1/1] SOUND: wm8753, remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1283769150.3078.15.camel@odin>
Date:	Mon, 06 Sep 2010 11:32:30 +0100
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	tiwai@...e.de, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, jirislaby@...il.com,
	Liam Girdwood <lg@...nsource.wolfsonmicro.com>,
	Jaroslav Kysela <perex@...e.cz>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH 1/1] SOUND: wm8753, remove dead code

On Sat, 2010-09-04 at 15:12 +0200, Jiri Slaby wrote:
> There is adangling code in wm8753_probe which is never executed.
> Remove it.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Liam Girdwood <lg@...nsource.wolfsonmicro.com>
> Cc: Takashi Iwai <tiwai@...e.de>
> Cc: Jaroslav Kysela <perex@...e.cz>
> ---
>  sound/soc/codecs/wm8753.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/codecs/wm8753.c b/sound/soc/codecs/wm8753.c
> index 4844232..4a945d3 100644
> --- a/sound/soc/codecs/wm8753.c
> +++ b/sound/soc/codecs/wm8753.c
> @@ -1600,9 +1600,6 @@ static int wm8753_probe(struct snd_soc_codec *codec)
>  	wm8753_add_widgets(codec);
>  
>  	return 0;
> -
> -	run_delayed_work(&codec->delayed_work);
> -	return ret;
>  }
>  
>  /* power down chip */

Acked-by: Liam Girdwood <lrg@...mlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/