linux-kernel - Re: [PATCH] Function btree_get_extent: Incorrect if-else if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTimXO7td7xxD1_MVACjbKomE0VBLLV7A1U0z00eR@mail.gmail.com>
Date:	Mon, 6 Sep 2010 22:15:02 +0800
From:	Zhu Yanhai <zhu.yanhai@...il.com>
To:	André Nogueira <andre.neo.net@...il.com>
Cc:	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Function btree_get_extent: Incorrect if-else if statement

This is not correct.

2010/8/9 André Nogueira <andre.neo.net@...il.com>:
> The btree_get_extent function (in file disk-io.c) calls the
> add_extent_mapping (in file extent_map.c). The add_extent_mapping
> function can return two values: 0 or -EEXIST.

It might return some other error values besides -EEXIST, the 'else if
(ret)' branch
is just against them.
Namely, we should do some thing special when EEXIST, and do another things
for all other errors.

Regards,
Zhu Yanhai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/