linux-kernel - Re: [PATCH 06/14] staging: rtl8192u: improve error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100906180240.GC2764@bicker>
Date:	Mon, 6 Sep 2010 20:02:40 +0200
From:	Dan Carpenter <error27@...il.com>
To:	Kulikov Vasiliy <segooon@...il.com>
Cc:	kernel-janitors@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Julia Lawall <julia@...u.dk>,
	Ben Hutchings <ben@...adent.org.uk>,
	Mike Gilks <mike.kernel@...ksonline.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/14] staging: rtl8192u: improve error path

On Mon, Sep 06, 2010 at 05:50:56PM +0400, Kulikov Vasiliy wrote:
> On Mon, Sep 06, 2010 at 12:11 +0200, Dan Carpenter wrote:
> > On Sun, Sep 05, 2010 at 10:32:41PM +0400, Kulikov Vasiliy wrote:
> > > +fail2:
> > > +	rtl8192_down(dev);
> > > +	if (priv->pFirmware) {
> > > +		kfree(priv->pFirmware);
> > > +		priv->pFirmware = NULL;
> > > +	}
> > > +	rtl8192_usb_deleteendpoints(dev);
> > > +	destroy_workqueue(priv->priv_wq);
> > > +	mdelay(10);
> > 
> > What's this delay for?
> 
> It was copied from rtl8192_usb_disconnect(), I don't know why it has
> mdelay(10). But it's better to keep the old deallocation code, it should
> have the same problems (if original code has any).
> 

I think the delay in rtl8192_usb_disconnect() is because we reset the
device.  (Of course, in that case, it would have been better to move the
delay into rtl8192_reset().  And also the reset code has been commented
out.)

In this case here, the delay is serves no purpose and should be removed.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/