linux-kernel - Re: [PATCH 02/14] arch/h8300: Removing dead ifdef __H8300_TLB_H_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 06 Sep 2010 20:32:27 +0200
From:	Andreas Schwab <schwab@...ux-m68k.org>
To:	Christian Dietrich <qy03fugy@...d.informatik.uni-erlangen.de>
Cc:	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	linux-kernel@...r.kernel.org,
	vamos-dev@...informatik.uni-erlangen.de
Subject: Re: [PATCH 02/14] arch/h8300: Removing dead ifdef __H8300_TLB_H__

Christian Dietrich <qy03fugy@...d.informatik.uni-erlangen.de> writes:

> The nested __H8300_TLB_H__ include guard isn't necessary at this point,
> because the symbol is always defined at this point and the block
> content will always be removed.
>
> Signed-off-by: Christian Dietrich <qy03fugy@...d.informatik.uni-erlangen.de>
> ---
>  arch/h8300/include/asm/tlb.h |   13 -------------
>  1 files changed, 0 insertions(+), 13 deletions(-)
>
> diff --git a/arch/h8300/include/asm/tlb.h b/arch/h8300/include/asm/tlb.h
> index 3dea80a..6339a02 100644
> --- a/arch/h8300/include/asm/tlb.h
> +++ b/arch/h8300/include/asm/tlb.h
> @@ -7,17 +7,4 @@
>  
>  #define tlb_flush(tlb)	do { } while(0)
>  
> -/* 
> -  include/asm-h8300/tlb.h 
> -*/
> -
> -#ifndef __H8300_TLB_H__
> -#define __H8300_TLB_H__
> -
> -#define tlb_flush(tlb)	do { } while(0)
> -
> -#include <asm-generic/tlb.h>
> -
> -#endif
> -
>  #endif

Looks like someone patched the file twice with the same patch, see
<http://git.kernel.org/?p=linux/kernel/git/tglx/history.git;a=commitdiff;h=398f579808cb74dd4c418df72ff8ff5971038e4f#patch24>

Andreas.

-- 
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/