linux-kernel - Re: [tip:x86/irq] x86: Always use irq stacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1283799222.15941.1393621887@webmail.messagingengine.com>
Date:	Mon, 06 Sep 2010 20:53:42 +0200
From:	"Alexander van Heukelum" <heukelum@...tmail.fm>
To:	"Ingo Molnar" <mingo@...e.hu>, mingo@...hat.com,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
	hch@....de, "Thomas Gleixner" <tglx@...utronix.de>
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/irq] x86: Always use irq stacks

On Fri, 03 Sep 2010 17:00 +0200, "Ingo Molnar" <mingo@...e.hu> wrote:
> 
> * tip-bot for Christoph Hellwig <hch@....de> wrote:
> 
> > Commit-ID:  7974891db234467eaf1fec613ec0129cb4ac2332
> > Gitweb:     http://git.kernel.org/tip/7974891db234467eaf1fec613ec0129cb4ac2332
> > Author:     Christoph Hellwig <hch@....de>
> > AuthorDate: Mon, 28 Jun 2010 14:15:54 +0200
> > Committer:  Thomas Gleixner <tglx@...utronix.de>
> > CommitDate: Tue, 29 Jun 2010 12:12:59 +0200
> > 
> > x86: Always use irq stacks
>
> [...]
> 
> Checking out 7974891db2 and building+booting a kernel with this config 
> causes shows the crash.
> 
> Checking out 7974891db2~1 and building+booting a kernel with this config 
> gives a working system.
> 
> Note that tip:x86/irq has these commits currently:
> 
>  1813a68: x86: Move alloc_desk_mask variables inside ifdef
>  2589737: x86-32: Align IRQ stacks properly
>  dcfa726: x86: Remove CONFIG_4KSTACKS
>  7974891: x86: Always use irq stacks

Hello Ingo, Christoph, ...

There is still a problem with the alignment of the irq stacks. Maybe it's only
theoretical, but I think the attached patch is necessary. (Attached because
I'm sending it via a web interface.)

Please test and apply :).

Greetings,
    Alexander

> Thanks,
> 
> 	Ingo
> 


View attachment "0001-i386-Align-percpu-area-and-irq-stacks-to-THREAD_SIZE.patch" of type "text/x-patch" (2648 bytes)