linux-kernel - Re: [PATCH] ARM: pxa27x_keypad: added a comment to explain clear_wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTi=9tbLYZO7QPCBiEeUTeedz+wuaAWanEuY4CSO2@mail.gmail.com>
Date:	Mon, 6 Sep 2010 11:50:07 +0800
From:	Eric Miao <eric.y.miao@...il.com>
To:	"Mark F. Brown" <mark.brown314@...il.com>
Cc:	grinberg@...pulab.co.il, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, haojian.zhuang@...vell.com
Subject: Re: [PATCH] ARM: pxa27x_keypad: added a comment to explain
 clear_wakeup_event callback

On Sun, Sep 5, 2010 at 11:33 PM, Mark F. Brown <mark.brown314@...il.com> wrote:
> Signed-off-by: Mark F. Brown <mark.brown314@...il.com>
> ---
>  arch/arm/plat-pxa/include/plat/pxa27x_keypad.h |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-pxa/include/plat/pxa27x_keypad.h b/arch/arm/plat-pxa/include/plat/pxa27x_keypad.h
> index 73dacda..abcc36e 100644
> --- a/arch/arm/plat-pxa/include/plat/pxa27x_keypad.h
> +++ b/arch/arm/plat-pxa/include/plat/pxa27x_keypad.h
> @@ -25,6 +25,13 @@
>  *
>  * 4. matrix key and direct key will use the same debounce_interval by
>  *    default, which should be sufficient in most cases
> + *
> + * pxa168 keypad platform specific parameter
> + *
> + * NOTE:
> + * clear_wakeup_event callback is a workaround required to clear the
> + * keypad interrupt. The keypad wake must be cleared in addition to
> + * reading the MI/DI bits in the KPC register.
>  */
>  struct pxa27x_keypad_platform_data {
>
> @@ -52,6 +59,8 @@ struct pxa27x_keypad_platform_data {
>
>        /* key debounce interval */
>        unsigned int    debounce_interval;
> +
> +       /* clear wakeup event requirement for pxa168 */
>        void            (*clear_wakeup_event)(void);
>  };
>
> --
> 1.7.0.4
>
>

Merged into below commit, and 'devel' branch pushed.

  ARM: pxa27x_keypad: added wakeup event handler for keypad interrupts

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/