| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 7 Sep 2010 10:03:03 +0200 From: Jean Delvare <khali@...ux-fr.org> To: Jan Beulich <JBeulich@...ell.com> Cc: Fenghua Yu <fenghua.yu@...el.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "lm-sensors@...sensors.org" <lm-sensors@...sensors.org>, "hpa@...or.com" <hpa@...or.com>, "mingo@...e.hu" <mingo@...e.hu>, "tglx@...utronix.de" <tglx@...utronix.de> Subject: Re: [lm-sensors] [PATCH] x86/hwmon: fix configuration and initialization of coretemp and pkgtemp On Thu, 2 Sep 2010 14:25:05 -0700, Fenghua Yu wrote: > On Thu, Sep 02, 2010 at 05:44:07AM -0700, Jan Beulich wrote: > > - using cpuid_eax() to determine feature availability on other than > > the current CPU is invalid > > - feature availability shopuld also be check in the hotplug code path > > - pkgtemp doesn't depend on PCI altogether (apparently just inherited > > from coretemp) > > - coretemp really only needs PCI for Atom support > > > > Could you split the patch into small patches since it handles a few different > things? I can only second this request. This should be split into per-driver patches or per-bug patches, or even both. Jan, can you please send updated patches? I can't apply that one as is. Thanks. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists