linux-kernel - Re: [PATCH] perf, x86: Disable perf if the BIOS got its grubby paws on the PMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100907165158.GB13563@erda.amd.com>
Date:	Tue, 7 Sep 2010 18:51:58 +0200
From:	Robert Richter <robert.richter@....com>
To:	Peter Zijlstra <peterz@...radead.org>
CC:	Matt Domsch <Matt_Domsch@...l.com>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Ingo Molnar <mingo@...e.hu>,
	Stephane Eranian <eranian@...gle.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...ux.kernel.org>
Subject: Re: [PATCH] perf, x86: Disable perf if the BIOS got its grubby
 paws on the PMU

On 07.09.10 17:15:41, Robert Richter wrote:
> > > > On 9/3/2010 2:13 AM, Peter Zijlstra wrote:
> > > > >+static void print_BIOS_fail(void)
> > > > >+{
> > > > >+	printk(KERN_ERR "\n");
> > > > >+	printk(KERN_ERR "=============================================\n");
> > > > >+	printk(KERN_ERR "It appears the BIOS is actively using the PMU\n");
> > > > >+	printk(KERN_ERR "this avoids Linux from using it, please de-  \n");
> > > > >+	printk(KERN_ERR "activate this BIOS feature or request a BIOS \n");
> > > > >+	printk(KERN_ERR "update from your vendor.                     \n");
> > > > >+	printk(KERN_ERR "=============================================\n");
> 
> I would rather prefer this:
> 
>  BIOS bug, cpu 1, invalid  <register=value> ...

I got the note there is already a macro for this in kernel.h:

 #define FW_BUG          "[Firmware Bug]: "

So, we would have something like:

 [Firmware Bug]: cpu 1, invalid  <register=value> ...

in dmesg.

-Robert

> 
> ... which is a much better information on one line, explains the bug
> and is also better parsable. I intend to implement messages like
> this. So maybe we could find consensus with this or something similar.
> 
> A simple grep of dmesg will then give a list of BIOS bugs.
> 
> -Robert
> 
> -- 
> Advanced Micro Devices, Inc.
> Operating System Research Center

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/