linux-kernel - Re: [RFC 04/22] tcm: Add v4 base data structures and struct target_core_fabric

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201009071656.21568.konrad@darnok.org>
Date:	Tue, 7 Sep 2010 16:56:20 -0400
From:	Konrad Rzeszutek Wilk <konrad@...nok.org>
To:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
Cc:	"linux-scsi" <linux-scsi@...r.kernel.org>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Mike Christie <michaelc@...wisc.edu>,
	Christoph Hellwig <hch@....de>, Hannes Reinecke <hare@...e.de>,
	James Bottomley <James.Bottomley@...e.de>,
	Jens Axboe <axboe@...nel.dk>,
	Boaz Harrosh <bharrosh@...asas.com>
Subject: Re: [RFC 04/22] tcm: Add v4 base data structures and struct target_core_fabric_ops

> Hi Konard,
>
> I just pushed most of your recommend cleanups for target_core_base.h to
> lio-core-2.6.git/lio-4.0.  The cleanup series has been posted on
> lio-devel list to prevent extra noise on linux-scsi, et al, but for
> reference the shortlog and diffstat are attached below..  I did not dive
> into intermixed struct + #defines, but I am still pretty indifferent on
> this particular item.
>

So the reasons why I thought it would be a good idea to combine the #defines 
and the values and also dropping the prefix of structs for all of the 'flag' 
members is that:

1) once you have them intermixed, searching for a particular flag either using 
cscope/ctags becomes easier. You have the definition of the 'flag' and the 
different values it can have in one localized spot. It also removes your 
worry about the 'grep' - you usually search for the values that a specific 
flag has and if you use that tool you can find it right there along with the
structure it was defined in.

2). From a perspective of a vendor maintainer who has to find a fix, getting
 familiarized with the code within a short window time frame and having the 
acceptable states and its definitions in one place (and even pointers to the 
specs if there are some) makes it sooo much easier to grok the code.
Having even nice ascii art of how/what works together is even better.

Obviously thought there are tools that can do this for you. But when the bug 
hits I somehow never managed to have those tools ready :-(

>
> Please have a look and feel free to make additional comments.

Sure.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/