linux-kernel - Re: [PATCH] Remove implicit list prefetches for most cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100908154514.7c8596ae@basil.nowhere.org>
Date:	Wed, 8 Sep 2010 15:45:14 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Paul Moore <paul.moore@...com>
Cc:	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
	x86@...nel.org, Al Viro <viro@...IV.linux.org.uk>,
	arjan@...radead.org, davem@...emloft.net
Subject: Re: [PATCH] Remove implicit list prefetches for most cases


> 
> If prefetch() is generally considered a "Bad Thing", 

Using it unconditionally in list_for_each style operations at least is.
> 
I'm OK with just
> removing them from NetLabel; no need to rename and conditionalize.  I
> put them in the netlbl_af[4,6]list_*() routines because those routines
> were modeled after the normal list routines which had prefetches and I
> just assumed someone much smarter had found them to be a win.

Unless you have gigantic list walk bodies they are unlikely to be
on anything modern. 

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/