linux-kernel - Re: [patch 02/30] input: misc/hp_sdc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Sep 2010 08:37:45 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [patch 02/30] input: misc/hp_sdc_rtc: semaphore cleanup

On Tue, Sep 07, 2010 at 02:31:58PM -0000, Thomas Gleixner wrote:
> Get rid of init_MUTEX[_LOCKED]() and use sema_init() instead.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Dmitry Torokhov <dtor@...l.ru>

All 3 look good to me Thomas, please merge with the rest of the patch
series.

> 
> ---
>  drivers/input/misc/hp_sdc_rtc.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6/drivers/input/misc/hp_sdc_rtc.c
> ===================================================================
> --- linux-2.6.orig/drivers/input/misc/hp_sdc_rtc.c
> +++ linux-2.6/drivers/input/misc/hp_sdc_rtc.c
> @@ -104,7 +104,7 @@ static int hp_sdc_rtc_do_read_bbrtc (str
>  	t.endidx =		91;
>  	t.seq =			tseq;
>  	t.act.semaphore =	&tsem;
> -	init_MUTEX_LOCKED(&tsem);
> +	sema_init(&tsem, 0);
>  	
>  	if (hp_sdc_enqueue_transaction(&t)) return -1;
>  	
> @@ -698,7 +698,7 @@ static int __init hp_sdc_rtc_init(void)
>  		return -ENODEV;
>  #endif
>  
> -	init_MUTEX(&i8042tregs);
> +	sema_init(&i8042tregs, 1);
>  
>  	if ((ret = hp_sdc_request_timer_irq(&hp_sdc_rtc_isr)))
>  		return ret;
> 
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/