linux-kernel - Re: [PATCH 42/41 v2] dm: convey that all flushes are processed as empty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C87B547.5080700@kernel.org>
Date:	Wed, 08 Sep 2010 18:09:43 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Mike Snitzer <snitzer@...hat.com>
CC:	Christoph Hellwig <hch@....de>, jack@...e.cz, mst@...hat.com,
	linux-ide@...r.kernel.org,
	device-mapper development <dm-devel@...hat.com>,
	James.Bottomley@...e.de, konishi.ryusuke@....ntt.co.jp,
	k-ueda@...jp.nec.com, vst@...b.net, linux-scsi@...r.kernel.org,
	rusty@...tcorp.com.au, linux-raid@...r.kernel.org,
	mpatocka@...hat.com, swhiteho@...hat.com, chris.mason@...cle.com,
	tytso@....edu, jaxboe@...ionio.com, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, rwheeler@...hat.com,
	Milan Broz <mbroz@...hat.com>
Subject: Re: [PATCH 42/41 v2] dm: convey that all flushes are processed as
 empty

On 09/08/2010 04:04 AM, Mike Snitzer wrote:
> Rename __clone_and_map_flush to __clone_and_map_empty_flush for added
> clarity.
> 
> Simplify logic associated with REQ_FLUSH conditionals.
> 
> Introduce a BUG_ON() and add a few more helpful comments to the code
> so that it is clear that all flushes are empty.
> 
> Cleanup __split_and_process_bio() so that an empty flush isn't processed
> by a 'sector_count' focused while loop.
> 
> Signed-off-by: Mike Snitzer <snitzer@...hat.com>
> ---
>  drivers/md/dm.c |   34 +++++++++++++++-------------------
>  1 files changed, 15 insertions(+), 19 deletions(-)
> 
> Tejun, please feel free to fold this patch into (or insert after)
> 0025-dm-relax-ordering-of-bio-based-flush-implementation.patch

I added it after 26 and updated flush-fua branch accordingly.

Thank you.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/